Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(exa PR) 869: Make sort more consistent accross uses and flags #57

Closed
wants to merge 1 commit into from

Conversation

cafkafk
Copy link
Member

@cafkafk cafkafk commented Jul 29, 2023

In some cases, files were sorted twice, which in most cases is harmless.
But when two files are determined equal, their order is unchanged (because the sort is stable).
With `--reverse`, equal elements order, which wasn’t changed by the sort, were reversed twice (unchanged).

Also, command lines arguments are now sorted by their path.
@cafkafk
Copy link
Member Author

cafkafk commented Jul 29, 2023

This has unresolved conflicts: ogham/exa#869 (comment)

@cafkafk cafkafk added the not ready for PRs that aren't finished label Jul 29, 2023
@cafkafk cafkafk changed the title (exa PR) 869 (exa PR) 869: Make sort more consistent accross uses and flags Jul 29, 2023
@cafkafk cafkafk marked this pull request as draft July 30, 2023 04:17
@sbatial sbatial mentioned this pull request Jul 30, 2023
63 tasks
@cafkafk cafkafk added this to the exa pulls done milestone Jul 31, 2023
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

This pull request is stale because it has been open for 30 days with no activity.

@github-actions
Copy link

This pull request was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this Sep 19, 2023
@cafkafk cafkafk deleted the pr-869 branch October 12, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not ready for PRs that aren't finished stale › pr
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants