fix: update MSRV to 1.78 to solve tv_nsec related panics #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the Windows automations aren't happy but I don't have a Windows PC to check them out any more, sorry! |
Dw I'm on it :p |
cafkafk
added a commit
that referenced
this pull request
Jan 23, 2025
Apparently, upstream rust decided to change the behavior of dead/unused code detection in a way that causes a lot of false positives. For some (yet known) reason, this only hit on the windows build, but I've confirmed that these are indeed false positives, and removing this "dead code" breaks the build. Frustratingly, we only hit this to fix *another issue*[1] with upstream rust... And this litters our code with directives where we "allow unused" that isn't unused. I coindicentally also saw this at dayjob today[2], and yes, this is real, so we'll just have to do it. Refs: [1] rust-lang/rust@e69f14b Refs: [2] DBCDK/faythe#101 Refs: rust-lang/rust#88900 Refs: #1342 Signed-off-by: Christina Sørensen <ces@fem.gg>
This updated the rust MSRV to resolve a bug in the actual upstream rust implementation that has been affecting eza for a while. This obviously means new eza releases won't be available on all distributions, but those distributions should move to a new version of rust then, since this bug seems to indicate that there is an important issue here. Closes: #735 Refs: #666 rust-lang/rust@e69f14b Signed-off-by: Christina Sørensen <ces@fem.gg>
Apparently, upstream rust decided to change the behavior of dead/unused code detection in a way that causes a lot of false positives. For some (yet known) reason, this only hit on the windows build, but I've confirmed that these are indeed false positives, and removing this "dead code" breaks the build. Frustratingly, we only hit this to fix *another issue*[1] with upstream rust... And this litters our code with directives where we "allow unused" that isn't unused. I coindicentally also saw this at dayjob today[2], and yes, this is real, so we'll just have to do it. Refs: [1] rust-lang/rust@e69f14b Refs: [2] DBCDK/faythe#101 Refs: rust-lang/rust#88900 Refs: #1342 Signed-off-by: Christina Sørensen <ces@fem.gg>
|
I'll add the commit message here for visibility |
cafkafk
changed the title
cafkafk
added a commit
that referenced
this pull request
Jan 23, 2025
Apparently, upstream rust decided to change the behavior of dead/unused code detection in a way that causes a lot of false positives. For some (yet known) reason, this only hit on the windows build, but I've confirmed that these are indeed false positives, and removing this "dead code" breaks the build. Frustratingly, we only hit this to fix *another issue*[1] with upstream rust... And this litters our code with directives where we "allow unused" that isn't unused. I coindicentally also saw this at dayjob today[2], and yes, this is real, so we'll just have to do it. Refs: [1] rust-lang/rust@e69f14b Refs: [2] DBCDK/faythe#101 Refs: rust-lang/rust#88900 Refs: #1342 Signed-off-by: Christina Sørensen <ces@fem.gg>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updated the rust MSRV to resolve a bug in the actual upstream rust
implementation that has been affecting eza for a while.
This obviously means new eza releases won't be available on all
distributions, but those distributions should move to a new version of
rust then, since this bug seems to indicate that there is an important
issue here.
Closes: #735
Refs: #666 rust-lang/rust@e69f14b
Signed-off-by: Christina Sørensen ces@fem.gg