Add support for Symfony 7 #40
Conversation
|
Hi @relthyg |
|
Hi @eymengunay, thanks for reaching out! Yes, that was intentional, as I'm not using the PR version in production yet. I wanted to release it for merging as soon as I see there are no issues. |
|
Hi @eymengunay, the PR is now up for grabs! |
|
Hey @relthyg |
|
Thanks for merging! Would you mind tagging a new release? |
|
Sure thing. Here is the new tag: https://github.com/eymengunay/EoHoneypotBundle/releases/tag/v2.2.0 Thanks again for your help! |
|
Always a pleasure! |
| @@ -58,7 +58,7 @@ public function __construct(RequestStack $requestStack, HoneypotManager $honeypo | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| public function buildForm(FormBuilderInterface $builder, array $options) | |||
| public function buildForm(FormBuilderInterface $builder, array $options): void | |||
There was a problem hiding this comment.
@eymengunay adding return types in non-final classes is actually a bc break if it's done in a minor (same with the other methods in this class). This currently break applications extending this class after the update to 2.2.0
No description provided.