Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add first rendering tests #445

Closed
wants to merge 1 commit into from
Closed

Add first rendering tests #445

wants to merge 1 commit into from

Conversation

f3dm76
Copy link
Collaborator

@f3dm76 f3dm76 commented Jul 2, 2018

No description provided.

ystrot
ystrot requested changes Jul 9, 2018
View reviewed changes
Copy link
Member

@ystrot ystrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, few general notes:

  • Use PNG instead of JPEG for image comparison
  • Let's store images outside of this repo. It can be another repo or separate image hosting service.

@ystrot ystrot self-assigned this Jul 9, 2018
mgoldin pushed a commit that referenced this pull request May 14, 2019
Fix #445: add png images to project directiory, add image validation …
5767fb2 
…into JSON validation
mgoldin pushed a commit that referenced this pull request May 31, 2019
Fix #445 drop isDebug flag and use shouldSaveFaildedTestImage flag
6cb6104
mgoldin pushed a commit that referenced this pull request May 31, 2019
Fix #445 update png resources
f129cb0
mgoldin pushed a commit that referenced this pull request May 31, 2019
Fix #445 turn of internal test flahs
00b6cf7
mgoldin pushed a commit that referenced this pull request May 31, 2019
Fix #445 vaidate PNG only on mac
dbe670c
mgoldin pushed a commit that referenced this pull request May 31, 2019
Fix #445 drop test readme
3cdc39b
mgoldin pushed a commit that referenced this pull request Jun 3, 2019
Fix #445 codestyle fixes
87c5b67
mgoldin pushed a commit that referenced this pull request Jun 3, 2019
Fix #445 update test usage description
c976820
mgoldin pushed a commit that referenced this pull request Jun 3, 2019
Fix #445 add missing png
1d07449
mnndnl pushed a commit that referenced this pull request Jun 3, 2019
#445 change reference image for svg test masking-mask-02
c096fae
mgoldin pushed a commit that referenced this pull request Jun 4, 2019
Fix #445 remove duplicated resourses frm compile sources
c5db5ae
mgoldin pushed a commit that referenced this pull request Jun 4, 2019
Revert "Fix #445 remove duplicated resourses frm compile sources"
8dff74c 
This reverts commit c5db5ae.
mgoldin pushed a commit that referenced this pull request Jun 4, 2019
Fix #445 remove duplicated resourses frm compile sources #2
04ad935
@ystrot ystrot added this to the 0.9.6 milestone Jun 4, 2019
@ystrot ystrot closed this in 7e9151e Jun 4, 2019
@ystrot ystrot modified the milestones: 0.9.6, 0.9.7 Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ystrot ystrot ystrot requested changes

Assignees

@ystrot ystrot

@mgoldin mgoldin

Labels
None yet
Projects
None yet
Milestone
0.9.7
Development

Successfully merging this pull request may close these issues.
3 participants
@f3dm76 @ystrot @mgoldin