Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redact password and license key from output #55

Merged
merged 2 commits into from
Apr 2, 2018
Merged

Redact password and license key from output #55

merged 2 commits into from
Apr 2, 2018

Conversation

warrenvw
Copy link
Contributor

@warrenvw warrenvw commented Apr 2, 2018

Fix #54.

@warrenvw warrenvw added the RFR label Apr 2, 2018
@warrenvw warrenvw self-assigned this Apr 2, 2018
@warrenvw warrenvw requested a review from arm4b April 2, 2018 06:40
arm4b
arm4b approved these changes Apr 2, 2018
View reviewed changes
Copy link
Contributor

@arm4b arm4b left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 👍

I remember after change like that need also to sync it into S3 bucket (bwc-installer).

@warrenvw warrenvw merged commit e402075 into master Apr 2, 2018
@warrenvw
Copy link
Contributor Author

warrenvw commented Apr 2, 2018

This sync to s3 should be automated. Created issue #56. I would have had no idea this change needed to be manually sync'd...

@warrenvw warrenvw deleted the wvw/redact_secrets branch April 2, 2018 19:07
@warrenvw
Copy link
Contributor Author

warrenvw commented Apr 2, 2018

It looks as though previous changes were not sync'd with s3 for quite some time...

install-suite.sh   Dec 16, 2016 10:31:13 PM GMT-0800
install.sh         Oct 9, 2017 8:41:00 AM GMT-0700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arm4b arm4b arm4b approved these changes

Assignees

@warrenvw warrenvw

Labels
RFR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@warrenvw @arm4b