Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branch names to rev log #713

Closed

Conversation

RexTremendae
Copy link
Contributor

Feature suggestion: add local branch names to the revlog. Personally I miss this feature a lot, I use it daily on the command line when working in a team that consists of more people than me :D
feature_branchnames

@extrawurst
Copy link
Owner

extrawurst commented May 16, 2021

dup of #81, right?

Totally missed that this is a PR and took it as an issue.

@RexTremendae interesting approach, but I think this needs to be tackled in #81. your implementation only bothers with annotating branches that accidentally share a commit with the Current head and its ancestors.

@extrawurst extrawurst closed this May 16, 2021
@extrawurst extrawurst reopened this May 16, 2021
@RexTremendae
Copy link
Contributor Author

@extrawurst I'm not sure what you mean by "accidently share a commit". This PR annotates the commits that are heads of local branches as far as I understand the Rust API. Compare the result with git log --graph --oneline on the command line.

@RexTremendae RexTremendae force-pushed the feature/BranchNames branch from 1b030f2 to 5f2a3be Compare May 16, 2021 17:17
@extrawurst
Copy link
Owner

@extrawurst I'm not sure what you mean by "accidently share a commit". This PR annotates the commits that are heads of local branches as far as I understand the Rust API. Compare the result with git log --graph --oneline on the command line.

without #81 you will only annotate the commits that are accidentally also on the current branch, since the revlog currently only shows commits on the current branch. therefore I cannot merge this :(

@extrawurst extrawurst marked this pull request as draft May 21, 2021 21:14
@extrawurst
Copy link
Owner

marking as draft for now

@RexTremendae RexTremendae force-pushed the feature/BranchNames branch 3 times, most recently from 4820266 to 4496a32 Compare May 28, 2021 19:14
@RexTremendae RexTremendae force-pushed the feature/BranchNames branch 2 times, most recently from e00f3d0 to 12a056b Compare June 8, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants