fix for linux hooks #386
Merged
fix for linux hooks #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extrawurst
requested changes
Oct 30, 2020
extrawurst
reviewed
Oct 30, 2020
extrawurst
reviewed
Oct 30, 2020
extrawurst
reviewed
Oct 30, 2020
|
FYI - this code works on both linux and windows on my dev system. But I think thats because I have WSL installed. I am not sure what will happen on the github test systems. So I have tests for both windows and non windows. I will check that in and see what happens. I have resolved all yr other issues. |
extrawurst
reviewed
Oct 31, 2020
extrawurst
reviewed
Oct 31, 2020
|
@pm100 two more things and we can merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit now works
also improved the layout of error message dialog to preserve the message formatting