-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No working oembed URLs #181
Comments
Thank you for your suggestion. My lib only focuses on the oembed api, and does not extract meta tag from the webpage, so it does not support something like twitter cards or open graph properties. But I may consider to implement that in the future. |
I may suggest adding the most important one like Facebook post, videos ect. Twitter already work well. I think if you find the right id it will work. But i think that some meta should be read like title, description ect. IFRAME: Post: Video: The Oembed json file will have to be done reading the header meta i guest. UPDATE: I did some test and i think it may not work because with JavaScript you are not logged in. mmm.... But my own php version give me this: |
With Facebook and Instagram, this lib requires to set app id and client token, as the doc here. I'm not sure that we can read these data without credentials. |
For Facebook, it will work with public post (My result confirm it work with php). I do not know if it will work with javascript and node. Example from NBC SPORT: Same with normal posts: |
@onigetoc what it showed is not oembed data but come from the webpage's meta tags. It find the oembed url but could not load the oembed without credentials. My oembed-extractor follows oEmbed standard:
So I don't have plan to parse the meta data from target page. I may create another project for that purpose in the future and this lib can use that package as a dependency. |
Some other services would work without explicitly being added to the list of providers should you implement oEmbed's method of discovery. For example, that bitchute page has discoverable oEmbed data. |
@CorySanin yeah, this is a great suggestion. |
Some work on some Oembed on node project lie (node-oembed), and some do not work from your's.
This one work with:
Not working with oembed-extractor:
for example: this one do not work with oembed but work on your's [oembed-extractor].
With PHP i used this one and it's really good. May be your can be inspired to custom some to make many more to work.
https://github.com/oscarotero/Embed/
I suggested him to add: Pinterest and some more.
I customized some myself to add more providers with a embed service but without Oembed infos in the header.
like - https://www.bitchute.com/video/8hXWnkvA8Ao/
Check for code or iframe:
The text was updated successfully, but these errors were encountered: