-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version3 #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Almenon
commented
Feb 14, 2021
•
edited
Loading
edited
- Resolves How to handle error when python's path is invalid? #118
- Reverts Update default python path for windows platform #168 which resolves Replace default python #237 and childProcess pid is not the same pid as python pid #236
- Linting
- Adds test
- adds reusable component for splitting streams
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
+ Coverage 94.94% 96.02% +1.07%
==========================================
Files 1 1
Lines 178 176 -2
Branches 43 41 -2
==========================================
Hits 169 169
+ Misses 9 7 -2
Continue to review full report at Codecov.
|
should try to keep consistent to minimize API changes for upstream devs
this breaks unit tests for some reason :(
I went in favor of a native solution. LineTransformStream had some bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.