Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version3 #233

Merged
merged 24 commits into from
Mar 27, 2021
Merged

Version3 #233

merged 24 commits into from
Mar 27, 2021

Conversation

Almenon
Copy link
Collaborator

@Almenon Almenon commented Feb 14, 2021

@Almenon Almenon changed the title Switch to promises WIP Switch to promises Feb 14, 2021
@Almenon Almenon marked this pull request as draft February 14, 2021 18:43
@Almenon Almenon changed the title WIP Switch to promises Switch to promises Feb 14, 2021
@codecov-io
Copy link

codecov-io commented Feb 14, 2021

Codecov Report

Merging #233 (a2c79a3) into master (2e44ea4) will increase coverage by 1.07%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage   94.94%   96.02%   +1.07%     
==========================================
  Files           1        1              
  Lines         178      176       -2     
  Branches       43       41       -2     
==========================================
  Hits          169      169              
+ Misses          9        7       -2     
Impacted Files Coverage Δ
index.ts 96.02% <92.30%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e44ea4...a2c79a3. Read the comment docs.

@Almenon Almenon changed the title Switch to promises Version3 Mar 8, 2021
@Almenon Almenon marked this pull request as ready for review March 8, 2021 05:21
@Almenon Almenon merged commit 1f854f3 into master Mar 27, 2021
@Almenon Almenon deleted the version2 branch March 27, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace default python How to handle error when python's path is invalid?
2 participants