Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for plug-in: YouTube_a #957

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Fix for plug-in: YouTube_a #957

merged 1 commit into from
Jun 16, 2022

Conversation

GrosPoulet
Copy link
Collaborator

- select video with max width available (any format)
- play links with timestart (e.g: https://youtu.be/qORYO0atB6g?t=28)
@GrosPoulet GrosPoulet added the bug label Jun 16, 2022
@GrosPoulet GrosPoulet merged commit 0d999bc into extesy:master Jun 16, 2022
@@ -83,7 +83,7 @@ hoverZoomPlugins.push({
cLog('href=' + href);

const re1 = /\/watch\?v=([^&]{1,})/; // sample: https://www.youtube.com/watch?v=NaOiA15Rz5k
const re2 = /\/youtu.be\/([^&]{1,})/; // sample: https://youtu.be/qXlQbj0PgDo
const re2 = /\/youtu.be\/([^?]{1,})/; // sample: https://youtu.be/qXlQbj0PgDo https://youtu.be/qORYO0atB6g?t=28
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GrosPoulet But you are still ignoring the actual time value. If the link points to the middle of the video, your code will start playing it from the beginning. You need to add #t=... to video url.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example: https://www.reddit.com/r/videos/comments/vdg6f7/beastie_boys_intergalactic/ - it should start playing from 28s mark, not from the very beginning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants