Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for red spinner: now not displayed by default #671

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

GrosPoulet
Copy link
Collaborator

@extesy, i first decided to remove all spinners (green, orange, red) but i changed my mind and kept the green one.
I spared it because it's the only visual clue for users that HZ+ is actually doing something (=trying to zoom the image under mouse pointer!).
Another option whould be to modify the look of image being hovered, like Imagus that adds a dotted border around image.
I did some tests, it is not fully reliable, so maybe we should keep the green spinner for now, what do you think?
By default, red and future orange spinners are disabled.

@extesy
Copy link
Owner

extesy commented Jan 28, 2021

I think there's a little conflict between the option description and it's tooltip. Can you please clarify what exactly this option (optDisplayImageLoader) is doing? Does it completely disable any spinner or just the error one? The message says "display image loader" but the tooltip says "orange & red spinners are optional". It almost sounds like the option toggles the whole spinner thingy and there should be a separate option just for error/orange ones.

@GrosPoulet GrosPoulet merged commit dd9ccbe into extesy:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants