Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Мигает текст страниц #847

Closed
Benia opened this issue Dec 22, 2021 · 6 comments
Closed

Мигает текст страниц #847

Benia opened this issue Dec 22, 2021 · 6 comments
Labels

Comments

@Benia
Copy link

Benia commented Dec 22, 2021

Мигает красным текст страниц на d3.ru и грузит процессор на 25%. На других сайтах проблема не проявляется.
Win 7, Chrome 96.0.4664.110 (Официальная сборка), (64 бит), HZ+ 1.0.186
https://cloud.mail.ru/public/27tt/KUbKpvfKK

upd: Откатился на предыдущую версию https://github.com/extesy/hoverzoom/releases/tag/1.0.185, всё заработало нормально.

@extesy extesy added the bug label Dec 23, 2021
@foxm666
Copy link

foxm666 commented Dec 23, 2021

Я несколько раз выключил и включил расширение и мигание исчезло. Потом опять появились, так что не работает метод, сорри

@GrosPoulet
Copy link
Collaborator

in english please

@GrosPoulet
Copy link
Collaborator

@extesy On this site (d3.ru), there's an issue with the text blinker i addd in lastest release.
Maybe because there's already some text blinking going on on d3.ru.
If i comment out line 312 in hoverzoom.js: no more issue.

@extesy
Copy link
Owner

extesy commented Dec 23, 2021

@GrosPoulet I wasn't able to reproduce it myself (I don't see any blinking) so thank you for finding a root cause. Do we even need this .blink style at all? Seems to be redundant with .videoErrorMsgCss in my opinion.

@StazMD
Copy link

StazMD commented Dec 24, 2021

Same for me. d3.ru is blinking with red.

@Benia
Copy link
Author

Benia commented Dec 24, 2021

Откат решает: https://github.com/extesy/hoverzoom/releases/tag/1.0.185

@extesy extesy closed this as completed in a411623 Dec 24, 2021
GrosPoulet added a commit to GrosPoulet/hoverzoom that referenced this issue Dec 31, 2021
Replacement of "blink" reserved word
GrosPoulet added a commit that referenced this issue Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants