This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
Fix annotation bugs #252
Merged
Fix annotation bugs #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If podAnnotations is empty then we should not try to add the annotations at all as they will be empty.
Before this change, if you tried providing a ServiceAccount annotation you will get the following error: `coalesce.go:199: warning: destination for annotations is a table. Ignoring non-table value <nil>` This addresses this by replacing the default for annotations with an empty object.
Flydiverny
approved these changes
Dec 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, if you tried providing a ServiceAccount annotation
you will get the following error from Helm:
coalesce.go:199: warning: destination for annotations is a table. Ignoring non-table value <nil>This fixes the default value so this issue doesn't happen.
There is also another fix for the annotations in the deployment so that it's more consistent with other areas. Without this, we generate an empty annotations section in the deployment when no podAnnotations are provided.