-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a field to DESCRIPTION to notify which version of rextendr
the package was created with
#225
Conversation
copied from roxygen2::roxygen_setup https://github.com/r-lib/roxygen2/blob/39d2dbefddac508dba6bffdec3a625cac7af16bc/R/roxygenize-setup.R
… to support the usethis.quiet option
1d03e47
to
29b78cd
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Ok, I tested it locally, seems to work fine. However, I am not entirely sure about the path in the config name. Is this because we want to avoid |
In my understanding, we don't really need this, but it's a common practice among tidyverse packages to use
It seems common field names like |
Ok, sounds fair. @eitsupi, let me know if you are finished with this PR -- I need to force-merge it to bypass 32-bit failing CI. |
Thank you all for your help.
The work is done and I would appreciate it if you could merge it if the field name is ok. |
Thank you for contributing @eitsupi ! |
Close #222
Like
roxygen2
(r-lib/roxygen2#338), record the version of the rextendr used to create the package in DESCRIPTION to prevent the use of older versions.It seems that the field name for this needs to start with
Config/
?https://github.com/wch/r-source/blob/d1618921e670f1607da77ba850949f8312abdff6/src/library/tools/R/QC.R#L7204-L7213