Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVPN-1521 Update to upstream wolfssl to 5.7.4 #189

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

kp-max-li
Copy link
Contributor

Moving from v5.7.2-stable
We are picking up:
https://github.com/wolfSSL/wolfssl/releases/tag/v5.7.4-stable

Updated to implement an important bugfix:
wolfSSL/wolfssl#8084

@CLAassistant
Copy link

CLAassistant commented Oct 28, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Oct 28, 2024

Code coverage summary for 29cc2ca:

Filename                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
wolfssl-sys/src/lib.rs                     5                 0   100.00%           2                 0   100.00%          24                 0   100.00%           0                 0         -
wolfssl/src/chacha20_poly1305.rs          14                 2    85.71%           5                 0   100.00%          95                 2    97.89%           0                 0         -
wolfssl/src/context.rs                   172                83    51.74%          45                14    68.89%         344               131    61.92%           0                 0         -
wolfssl/src/error.rs                      19                 7    63.16%           5                 1    80.00%          51                 9    82.35%           0                 0         -
wolfssl/src/lib.rs                        65                11    83.08%          14                 2    85.71%          81                12    85.19%           0                 0         -
wolfssl/src/rng.rs                        19                 5    73.68%           4                 0   100.00%          47                 3    93.62%           0                 0         -
wolfssl/src/ssl.rs                       471               202    57.11%          80                24    70.00%        1060               276    73.96%           0                 0         -
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                    765               310    59.48%         155                41    73.55%        1702               433    74.56%           0                 0         -

✅ Region coverage 59% passes
✅ Line coverage 74% passes

@kp-max-li kp-max-li force-pushed the CVPN-1521-update-wolfssl-to-5.7.4 branch 3 times, most recently from 6d63483 to fb59d29 Compare October 28, 2024 10:03
Moving from v5.7.2-stable
We are picking up:
https://github.com/wolfSSL/wolfssl/releases/tag/v5.7.4-stable

Updated to implement an important bugfix:
wolfSSL/wolfssl#8084
@kp-thomas-yau kp-thomas-yau force-pushed the CVPN-1521-update-wolfssl-to-5.7.4 branch from fb59d29 to 7073c3c Compare October 29, 2024 03:50
@kp-thomas-yau kp-thomas-yau changed the title CVPN-1521 update to upstream wolfssl to 5.7.4 CVPN-1521 Update to upstream wolfssl to 5.7.4 Oct 29, 2024
@kp-thomas-yau kp-thomas-yau marked this pull request as ready for review October 29, 2024 04:45
@kp-thomas-yau kp-thomas-yau requested a review from a team as a code owner October 29, 2024 04:45
@xv-raihaan-m
Copy link
Contributor

Commits 2 and 3 have 5.2.4 version number instead of 5.7.4

Variable names of some enums are changed after
the 5.7.4 update. See this commit for details:
wolfSSL/wolfssl@17870d4
After the update of wolfSSL to 5.7.4, some consts
generated by bindgen from the C enums became
c_uint. This broke the code as originally it was c_int.

Converting them to c_int to fix the code.
@kp-thomas-yau kp-thomas-yau force-pushed the CVPN-1521-update-wolfssl-to-5.7.4 branch from 7073c3c to fc1f7b9 Compare October 29, 2024 06:13
@kp-thomas-yau
Copy link
Contributor

Commits 2 and 3 have 5.2.4 version number instead of 5.7.4

@xv-raihaan-m fixed

@kp-thomas-yau kp-thomas-yau merged commit c6416d1 into main Oct 30, 2024
8 checks passed
@kp-thomas-yau kp-thomas-yau deleted the CVPN-1521-update-wolfssl-to-5.7.4 branch October 30, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants