Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed isNaN to use Number.isNaN instead #234

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changed isNaN to use Number.isNaN instead #234

wants to merge 1 commit into from

Conversation

nisalVD
Copy link

@nisalVD nisalVD commented Jul 12, 2019 •
edited
Loading

dougwilson
dougwilson suggested changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test for whatever this is fixing so we don't break it in the future.

@dougwilson dougwilson mentioned this pull request Jul 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougwilson dougwilson dougwilson requested changes

Assignees
No one assigned
Labels
needs tests pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nisalVD @dougwilson