Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update support Node.js@18 in the CI #5490

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

UlisesGascon
Copy link
Member

Main Changes

Add support for Node 18.19.1 in the CI and appveyor (c7e0758)

Note: Node 18.19.1 is last version available

Changelog

@UlisesGascon UlisesGascon marked this pull request as ready for review February 17, 2024 17:29
@UlisesGascon UlisesGascon mentioned this pull request Feb 17, 2024
3 tasks
Copy link
Member

@aravindvnair99 aravindvnair99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning to minor would be better than pinning to patch as then we wouldn't have to keep incrementing each time and can test for the latest release within that minor.

appveyor.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@dougwilson dougwilson merged commit 59af63a into expressjs:master Feb 19, 2024
24 checks passed
@shivam-sharma7
Copy link

@UlisesGascon Add support for node 20.x as well

@UlisesGascon
Copy link
Member Author

Thanks @shivam-sharma7. There is one for 20.x (#5429) and also 21.x (#5430)

@UlisesGascon UlisesGascon deleted the buils/support-node18 branch February 20, 2024 07:41
@UlisesGascon
Copy link
Member Author

Pinning to minor would be better than pinning to patch as then we wouldn't have to keep incrementing each time and can test for the latest release within that minor.

Fair point @aravindvnair99, but currently we want to be align with the latests Node.js versions in order to prevent issues with CITGM (see #5489)

@UlisesGascon UlisesGascon mentioned this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants