refactoring location in response #5316
Conversation
|
Thank you for this. Normally we do not accept style only changes, but I'm not sure what the reason for this change in since none was provided. I also see the comment is lost too explaining the special case. Can you elaborate on what this change's purpose is so we can evaluate it? |
|
It just seems to me that the design where we first assign the value of a variable is a little incorrect, then we look at its value and if it is equal to “back” we set something else. It seems to me that this could be done right away. |
|
Gorcha. I mean, it sounds like u are saying the style is not reallt to your liking, and I get that. We get a lot of comments on not liking some style over another, which is why we don't reallt take style-only changes, I am sorry. If you want to contribute a feature, you can code it in the style you like of course :) |
No description provided.