Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated String.prototype.substr() #4860

Merged
merged 1 commit into from
Mar 20, 2022
Merged

Replace deprecated String.prototype.substr() #4860

merged 1 commit into from
Mar 20, 2022

Conversation

CommanderRoot
Copy link
Contributor

String.prototype.substr() is deprecated so we replace it with String.prototype.slice() or String.prototype.substring() which work similarily but aren't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.

@dougwilson dougwilson added the pr label Mar 17, 2022
@dougwilson dougwilson self-assigned this Mar 20, 2022
Copy link
Contributor

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @CommanderRoot !

@dougwilson dougwilson merged commit 490f1a1 into expressjs:master Mar 20, 2022
himanshiLt pushed a commit to himanshiLt/express that referenced this pull request Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants