Add root support in res.download() #4855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougwilson
force-pushed
the
add-root-support-response-download
branch
from
3b13cae to
0f9c624
Compare
dougwilson
force-pushed
the
add-root-support-response-download
branch
from
0f9c624 to
0def9bb
Compare
This was referenced Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the abnormal root behaviour in
res.download()in #4834. It provides the non-breaking change to the code suggested in the linked issue (thus resolving the filename to an absolute path only ifoptions.rootis not set).I have:
res.download()relies onres.sendFile(), all of the various cases with root in options get dealt with in the sendFile tests).