This repository has been archived by the owner on Sep 14, 2022. It is now read-only.
Add support for cookie.secure === 'auto' #242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mirrors support in express-session where we look at the value of req.headers['x-forwarded-proto'] to automatically determine if we should set Secure. This provides the developer with a safe way of getting Secure set, without relying on complicated logic to detect development environments or set up branching middleware chains.
romerodiesan
approved these changes
Jun 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors support in express-session where we look
at the value of req.headers['x-forwarded-proto'] to
automatically determine if we should set Secure.
This provides the developer with a safe way of getting
Secure set, without relying on complicated logic to detect
development environments or set up branching middleware
chains.