ci: fix errors in ci github action for node 8 and 9 #523

inigomarquinez · 2024-05-05T18:58:25Z

This PR fixes nyc version to 14.1.1 when running tests in node 8 or node 9. nyc 15.x requires a yargs package version that requires node >=10.

I've also added the latest versions of node (20, 21 and 22) to the matrix.

Related to jshttp/http-errors#108

inigomarquinez · 2024-05-05T19:01:25Z

It seems that the tests fail for node >= 21, but not related to this PR itself, but to node itself.

UlisesGascon

LGTM!

wesleytodd · 2024-05-15T17:20:37Z

Ah, I am surprised we have more tests in here failing because of the query thing, but that is unrelated here. @jonchurch did you end up getting this fixed in that other branch? If so, mind dropping a link here so we don't have to repeat work to resolve it.

wesleytodd · 2024-05-17T23:05:06Z

I just tested locally and latest 22 does not fail. Do you want to update this to use 22.2.0? I am actually unsure what benefit we get from not just taking the latest in the major line, could we maybe just drop the minor specifier as well?

inigomarquinez · 2024-05-18T09:19:04Z

@wesleytodd , minor version removed from node 22. It still fails for node 21. Should I also removed minor version?

wesleytodd · 2024-05-22T19:27:20Z

Yeah I think we should remove the minor from all of them. We really want to be testing the latest in each major line without having to update all of them all the time.

inigomarquinez · 2024-05-24T10:07:46Z

@wesleytodd , I've removed the minor versions

@UlisesGascon , @carpasse , perhaps something to have in mind for all the other ci pipelines of the repositories we've been fixing/migrating 🤔

ctcpip · 2024-05-31T17:25:03Z

https://github.com/inigomarquinez/expressjs-body-parser/pull/1 addresses the failure in 21

Co-authored-by: Chris de Almeida <ctcpip@users.noreply.github.com>

![snyk-io[bot]](https://badgen.net/badge/icon/snyk-io%5Bbot%5D/green?label=) [<img width="16" alt="Powered by Pull Request Badge" src="https://user-images.githubusercontent.com/1393946/111216524-d2bb8e00-85d4-11eb-821b-ed4c00989c02.png">](https://pullrequestbadge.com/?utm_medium=github&utm_source=reisene&utm_campaign=badge_info) ![snyk-top-banner](https://redirect.github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123) <h3>Snyk has created this PR to upgrade body-parser from 1.20.3 to 2.0.1.</h3> :information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project. <hr/> ⚠️ **Warning:** This PR contains major version upgrade(s), and may be a breaking change. - The recommended version is **4 versions** ahead of your current version. - The recommended version was released **4 months ago**. <details> <summary><b>Release notes</b></summary> <br/> <details> <summary>Package name: <b>body-parser</b></summary> <ul> <li> <b>2.0.1</b> - <a href="https://redirect.github.com/expressjs/body-parser/releases/tag/2.0.1">2024-09-10</a></br><h2>What's Changed</h2> <ul> <li>Fix defaulting to extended url parsing by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/blakeembrey/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/blakeembrey">@ blakeembrey</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2515346637" data-permission-text="Title is private" data-url="expressjs/body-parser#536" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/536/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/536">#536</a></li> <li>Release: 2.0.1 by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/UlisesGascon/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/UlisesGascon">@ UlisesGascon</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2515354674" data-permission-text="Title is private" data-url="expressjs/body-parser#537" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/537/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/537">#537</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/blakeembrey/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/blakeembrey">@ blakeembrey</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2515346637" data-permission-text="Title is private" data-url="expressjs/body-parser#536" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/536/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/536">#536</a></li> </ul> <p><strong>Full Changelog</strong>: <a class="commit-link" href="https://redirect.github.com/expressjs/body-parser/compare/2.0.0...2.0.1"><tt>2.0.0...2.0.1</tt></a></p> </li> <li> <b>2.0.0</b> - <a href="https://redirect.github.com/expressjs/body-parser/releases/tag/2.0.0">2024-09-10</a></br><h2>What's Changed</h2> <h3>Important</h3> <ul> <li>add brotli support <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="656076290" data-permission-text="Title is private" data-url="expressjs/body-parser#406" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/406/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/406">#406</a></li> <li><strong>Breaking Change:</strong> Node.js 18 is the minimum supported version</li> </ul> <h3>Details</h3> <ul> <li>chore: add support for OSSF scorecard reporting by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/inigomarquinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/inigomarquinez">@ inigomarquinez</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2279511270" data-permission-text="Title is private" data-url="expressjs/body-parser#522" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/522/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/522">#522</a></li> <li>ci: fix errors in ci github action for node 8 and 9 by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/inigomarquinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/inigomarquinez">@ inigomarquinez</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2279679714" data-permission-text="Title is private" data-url="expressjs/body-parser#523" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/523/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/523">#523</a></li> <li>fix: pin to node@22.4.1 by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/wesleytodd/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/wesleytodd">@ wesleytodd</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2417531497" data-permission-text="Title is private" data-url="expressjs/body-parser#527" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/527/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/527">#527</a></li> <li>deps: qs@6.12.3 by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/melikhov-dev/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/melikhov-dev">@ melikhov-dev</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2243775909" data-permission-text="Title is private" data-url="expressjs/body-parser#521" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/521/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/521">#521</a></li> <li>Drop support for less than LTS node versions in v2 by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/wesleytodd/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/wesleytodd">@ wesleytodd</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2423856942" data-permission-text="Title is private" data-url="expressjs/body-parser#528" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/528/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/528">#528</a></li> <li>Also use the qs module for the simple parser by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/papandreou/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/papandreou">@ papandreou</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="562834397" data-permission-text="Title is private" data-url="expressjs/body-parser#387" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/387/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/387">#387</a></li> <li><code>raw-body@3</code> by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/wesleytodd/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/wesleytodd">@ wesleytodd</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2431088746" data-permission-text="Title is private" data-url="expressjs/body-parser#529" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/529/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/529">#529</a></li> <li>urlencoded: Support iso-8859-1, utf8 sentinel, and numeric entities by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/papandreou/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/papandreou">@ papandreou</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="346357762" data-permission-text="Title is private" data-url="expressjs/body-parser#326" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/326/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/326">#326</a></li> <li>Added support for brotli ('br') content-encoding by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/danielgindi/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/danielgindi">@ danielgindi</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="656076290" data-permission-text="Title is private" data-url="expressjs/body-parser#406" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/406/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/406">#406</a></li> <li>Add OSSF Scorecard badge by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/bjohansebas/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/bjohansebas">@ bjohansebas</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2456555585" data-permission-text="Title is private" data-url="expressjs/body-parser#531" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/531/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/531">#531</a></li> <li>Linter by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/UlisesGascon/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/UlisesGascon">@ UlisesGascon</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2515064856" data-permission-text="Title is private" data-url="expressjs/body-parser#534" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/534/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/534">#534</a></li> <li>Release: 1.20.3 by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/UlisesGascon/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/UlisesGascon">@ UlisesGascon</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2515075091" data-permission-text="Title is private" data-url="expressjs/body-parser#535" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/535/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/535">#535</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/inigomarquinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/inigomarquinez">@ inigomarquinez</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2279511270" data-permission-text="Title is private" data-url="expressjs/body-parser#522" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/522/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/522">#522</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/wesleytodd/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/wesleytodd">@ wesleytodd</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2417531497" data-permission-text="Title is private" data-url="expressjs/body-parser#527" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/527/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/527">#527</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/melikhov-dev/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/melikhov-dev">@ melikhov-dev</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2243775909" data-permission-text="Title is private" data-url="expressjs/body-parser#521" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/521/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/521">#521</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/papandreou/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/papandreou">@ papandreou</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="562834397" data-permission-text="Title is private" data-url="expressjs/body-parser#387" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/387/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/387">#387</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/danielgindi/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/danielgindi">@ danielgindi</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="656076290" data-permission-text="Title is private" data-url="expressjs/body-parser#406" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/406/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/406">#406</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/bjohansebas/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/bjohansebas">@ bjohansebas</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2456555585" data-permission-text="Title is private" data-url="expressjs/body-parser#531" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/531/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/531">#531</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/UlisesGascon/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/UlisesGascon">@ UlisesGascon</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2515064856" data-permission-text="Title is private" data-url="expressjs/body-parser#534" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/534/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/534">#534</a></li> </ul> <p><strong>Full Changelog</strong>: <a class="commit-link" href="https://redirect.github.com/expressjs/body-parser/compare/1.20.2...2.0.0"><tt>1.20.2...2.0.0</tt></a></p> </li> <li> <b>2.0.0-beta.2</b> - <a href="https://redirect.github.com/expressjs/body-parser/releases/tag/v2.0.0-beta.2">2023-02-23</a></br><p>This incorporates all changes after 1.19.1 up to 1.20.2.</p> <ul> <li>Remove deprecated <code>bodyParser()</code> combination middleware</li> <li>deps: debug@3.1.0 <ul> <li>Add <code>DEBUG_HIDE_DATE</code> environment variable</li> <li>Change timer to per-namespace instead of global</li> <li>Change non-TTY date format</li> <li>Remove <code>DEBUG_FD</code> environment variable support</li> <li>Support 256 namespace colors</li> </ul> </li> <li>deps: iconv-lite@0.5.2 <ul> <li>Add encoding cp720</li> <li>Add encoding UTF-32</li> </ul> </li> <li>deps: raw-body@3.0.0-beta.1</li> </ul> </li> <li> <b>2.0.0-beta.1</b> - <a href="https://redirect.github.com/expressjs/body-parser/releases/tag/v2.0.0-beta.1">2021-12-18</a></br><ul> <li><code>req.body</code> is no longer always initialized to <code>{}</code> <ul> <li>it is left <code>undefined</code> unless a body is parsed</li> </ul> </li> <li><code>urlencoded</code> parser now defaults <code>extended</code> to <code>false</code></li> <li>Use <code>on-finished</code> to determine when body read</li> </ul> </li> <li> <b>1.20.3</b> - <a href="https://redirect.github.com/expressjs/body-parser/releases/tag/1.20.3">2024-09-09</a></br><h2>What's Changed</h2> <h3>Important</h3> <ul> <li>deps: qs@6.13.0</li> <li>add <code>depth</code> option to customize the depth level in the parser</li> <li><strong>IMPORTANT:</strong> The default <code>depth</code> level for parsing URL-encoded data is now <code>32</code> (previously was <code>Infinity</code>). <a href="https://redirect.github.com/expressjs/body-parser/blob/17529513673e39ba79886a7ce3363320cf1c0c50/README.md#depth">Documentation</a></li> </ul> <h3>Other changes</h3> <ul> <li>chore: add support for OSSF scorecard reporting by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/inigomarquinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/inigomarquinez">@ inigomarquinez</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2279511270" data-permission-text="Title is private" data-url="expressjs/body-parser#522" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/522/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/522">#522</a></li> <li>ci: fix errors in ci github action for node 8 and 9 by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/inigomarquinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/inigomarquinez">@ inigomarquinez</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2279679714" data-permission-text="Title is private" data-url="expressjs/body-parser#523" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/523/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/523">#523</a></li> <li>fix: pin to node@22.4.1 by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/wesleytodd/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/wesleytodd">@ wesleytodd</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2417531497" data-permission-text="Title is private" data-url="expressjs/body-parser#527" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/527/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/527">#527</a></li> <li>deps: qs@6.12.3 by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/melikhov-dev/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/melikhov-dev">@ melikhov-dev</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2243775909" data-permission-text="Title is private" data-url="expressjs/body-parser#521" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/521/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/521">#521</a></li> <li>Add OSSF Scorecard badge by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/bjohansebas/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/bjohansebas">@ bjohansebas</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2456555585" data-permission-text="Title is private" data-url="expressjs/body-parser#531" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/531/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/531">#531</a></li> <li>Linter by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/UlisesGascon/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/UlisesGascon">@ UlisesGascon</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2515064856" data-permission-text="Title is private" data-url="expressjs/body-parser#534" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/534/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/534">#534</a></li> <li>Release: 1.20.3 by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/UlisesGascon/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/UlisesGascon">@ UlisesGascon</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2515075091" data-permission-text="Title is private" data-url="expressjs/body-parser#535" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/535/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/535">#535</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/inigomarquinez/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/inigomarquinez">@ inigomarquinez</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2279511270" data-permission-text="Title is private" data-url="expressjs/body-parser#522" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/522/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/522">#522</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/melikhov-dev/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/melikhov-dev">@ melikhov-dev</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2243775909" data-permission-text="Title is private" data-url="expressjs/body-parser#521" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/521/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/521">#521</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/bjohansebas/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/bjohansebas">@ bjohansebas</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2456555585" data-permission-text="Title is private" data-url="expressjs/body-parser#531" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/531/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/531">#531</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/UlisesGascon/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/UlisesGascon">@ UlisesGascon</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2515064856" data-permission-text="Title is private" data-url="expressjs/body-parser#534" data-hovercard-type="pull_request" data-hovercard-url="/expressjs/body-parser/pull/534/hovercard" href="https://redirect.github.com/expressjs/body-parser/pull/534">#534</a></li> </ul> <p><strong>Full Changelog</strong>: <a class="commit-link" href="https://redirect.github.com/expressjs/body-parser/compare/1.20.2...1.20.3"><tt>1.20.2...1.20.3</tt></a></p> </li> </ul> from <a href="https://redirect.github.com/expressjs/body-parser/releases">body-parser GitHub release notes</a> </details> </details> --- > [!IMPORTANT] > > - **Warning:** This PR contains a major version upgrade, and may be a breaking change. > - Check the changes in this PR to ensure they won't cause issues with your project. > - This PR was automatically created by Snyk using the credentials of a real user. --- **Note:** _You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs._ **For more information:** <img src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJmY2NmMTA2MC1iZmM1LTRjOWItOGFlMS0xZjczODJhYjI4YjEiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImZjY2YxMDYwLWJmYzUtNGM5Yi04YWUxLTFmNzM4MmFiMjhiMSJ9fQ==" width="0" height="0"/> > - 🧐 [View latest project report](https://app.snyk.io/org/reisene/project/55e114f8-489e-4f14-b900-20574b041e59?utm_source=github-cloud-app&utm_medium=referral&page=upgrade-pr) > - 📜 [Customise PR templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates?utm_source=&utm_content=fix-pr-template) > - 🛠 [Adjust upgrade PR settings](https://app.snyk.io/org/reisene/project/55e114f8-489e-4f14-b900-20574b041e59/settings/integration?utm_source=github-cloud-app&utm_medium=referral&page=upgrade-pr) > - 🔕 [Ignore this dependency or unsubscribe from future upgrade PRs](https://app.snyk.io/org/reisene/project/55e114f8-489e-4f14-b900-20574b041e59/settings/integration?pkg=body-parser&utm_source=github-cloud-app&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades) [//]: # 'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"body-parser","from":"1.20.3","to":"2.0.1"}],"env":"prod","hasFixes":false,"isBreakingChange":true,"isMajorUpgrade":true,"issuesToFix":[],"prId":"fccf1060-bfc5-4c9b-8ae1-1f7382ab28b1","prPublicId":"fccf1060-bfc5-4c9b-8ae1-1f7382ab28b1","packageManager":"npm","priorityScoreList":[],"projectPublicId":"55e114f8-489e-4f14-b900-20574b041e59","projectUrl":"https://app.snyk.io/org/reisene/project/55e114f8-489e-4f14-b900-20574b041e59?utm_source=github-cloud-app&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":4,"publishedDate":"2024-09-10T04:15:36.065Z"},"vulns":[]}' ## Podsumowanie przez Sourcery Ulepszenia: - Aktualizacja body-parser do wersji 2.0.1, która obejmuje: - Wsparcie dla kodowania Brotli - Rezygnację ze wsparcia dla starszych wersji Node.js - Domyślne ustawienie "extended" na "false" dla parsera urlencoded - Zmianę domyślnego poziomu głębokości parsowania danych URL-encoded do 32 <details> <summary>Original summary in English</summary> ## Summary by Sourcery Enhancements: - Upgrade body-parser to version 2.0.1, which includes support for Brotli encoding, drops support for older Node.js versions, defaults "extended" to "false" for urlencoded parser, and changes the default depth level for parsing URL-encoded data to 32. </details>

ci: fix errors in ci github action for node 8 and 9

bd70fd1

UlisesGascon approved these changes May 6, 2024

View reviewed changes

wesleytodd approved these changes May 15, 2024

View reviewed changes

wesleytodd mentioned this pull request May 17, 2024

deps: qs@6.12.3 #521

Merged

ci: remove minor version on node 22

8eff6fa

inigomarquinez requested a review from wesleytodd May 18, 2024 09:19

ci: remove minor versions

682461e

wesleytodd approved these changes May 24, 2024

View reviewed changes

inigomarquinez mentioned this pull request May 31, 2024

rebase: Generic Body Parser implemented #524

Closed

jonchurch mentioned this pull request Jun 5, 2024

2024-06-05 Express Working Session expressjs/discussions#240

Closed

jonchurch and others added 2 commits June 5, 2024 18:24

🧪 skip query test on node 21

2edaf6d

Co-authored-by: Chris de Almeida <ctcpip@users.noreply.github.com>

update query skip, actually skip, fix tracking issue link

b360292

jonchurch approved these changes Jun 9, 2024

View reviewed changes

fix lint error for ==

852555a

jonchurch merged commit 83db46a into expressjs:master Jun 9, 2024
26 checks passed

inigomarquinez deleted the ci/fix-tests-in-node-8-and-9 branch June 13, 2024 14:59

MilkaChucky mentioned this pull request Sep 10, 2024

Bump body-parser from 1.20.1 to 1.20.3 in /BookingWebApi MilkaChucky/BookingWebApp#93

Merged

Omrisnyk mentioned this pull request Sep 11, 2024

[Snyk] Fix for 4 vulnerabilities Omrisnyk/npm-lockfiles#183

Open

This was referenced Nov 9, 2024

[Snyk] Upgrade body-parser from 1.19.0 to 1.20.3 harrykimpel/dapr-samples#949

Open

[Snyk] Upgrade body-parser from 1.19.0 to 1.20.3 harrykimpel/dapr-samples#951

Open

snyk-matt mentioned this pull request Nov 9, 2024

[Snyk] Upgrade body-parser from 1.9.0 to 1.20.3 snyk-matt/goof-platform#21496

Open

This was referenced Nov 10, 2024

[Snyk] Upgrade body-parser from 1.19.0 to 1.20.3 harrykimpel/dapr-samples#954

Open

[Snyk] Upgrade body-parser from 1.19.0 to 1.20.3 harrykimpel/dapr-samples#956

Open

OyegokeTomisin mentioned this pull request Nov 10, 2024

[Snyk] Upgrade body-parser from 1.9.0 to 1.20.3 OyegokeTomisin/nodejs-goof#2

Open

KrishnaJallipalliQ mentioned this pull request Nov 10, 2024

[Snyk] Upgrade body-parser from 1.20.0 to 1.20.3 KrishnaJallipalliQ/ourNew#62

Open

sumanthreddy-a mentioned this pull request Nov 10, 2024

[Snyk] Upgrade body-parser from 1.18.3 to 1.20.3 sumanthreddy-a/cmp#1155

Open

zachan-dev mentioned this pull request Nov 10, 2024

[Snyk] Upgrade body-parser from 1.19.0 to 1.20.3 zachan-dev/zach-nodejs-caloriebuddy#86

Open

lenguyennhutdinh mentioned this pull request Nov 10, 2024

[Snyk] Upgrade body-parser from 1.20.2 to 1.20.3 lenguyennhutdinh/todo-list#144

Open

DevOpCar mentioned this pull request Nov 10, 2024

[Snyk] Upgrade body-parser from 1.9.0 to 1.20.3 DevOpCar/nodejs-goof#2

Open

UgoOluwa mentioned this pull request Nov 10, 2024

[Snyk] Upgrade body-parser from 1.9.0 to 1.20.3 UgoOluwa/nodejs-goof#2

Open

parseplatformorg mentioned this pull request Nov 10, 2024

refactor: Upgrade body-parser from 1.20.3 to 2.0.1 parse-community/parse-server#9425

Closed

harrykimpel mentioned this pull request Nov 10, 2024

[Snyk] Upgrade body-parser from 1.19.0 to 1.20.3 harrykimpel/dapr-samples#959

Open

msousa-fp mentioned this pull request Nov 11, 2024

[Snyk] Upgrade body-parser from 1.19.0 to 1.20.3 msousa-fp/basic-node-and-express#71

Open

kumailr7 mentioned this pull request Nov 11, 2024

[Snyk] Upgrade body-parser from 1.19.0 to 1.20.3 kumailr7/slack-docker#176

Open

jaebelle1 mentioned this pull request Nov 11, 2024

[Snyk] Upgrade body-parser from 1.9.0 to 1.20.3 jaebelle1/nodejs-goof#4

Open

mog-rn mentioned this pull request Nov 11, 2024

[Snyk] Upgrade body-parser from 1.19.0 to 1.20.3 mog-rn/football-stats-API#54

Open

Samax-DevOps mentioned this pull request Nov 11, 2024

[Snyk] Upgrade body-parser from 1.19.0 to 1.20.3 Samax-DevOps/Js-Docker-App#4

Open

MikeTeddyOmondi mentioned this pull request Nov 11, 2024

[Snyk] Upgrade body-parser from 1.20.2 to 1.20.3 MikeTeddyOmondi/joch-interiors#55

Open

HyunMinH mentioned this pull request Nov 11, 2024

[Snyk] Upgrade body-parser from 1.19.0 to 1.20.3 now-water/Reliable-Chatting-Platform#254

Open

Emmanuel97423 mentioned this pull request Nov 12, 2024

[Snyk] Upgrade body-parser from 1.19.0 to 1.20.3 Emmanuel97423/So_Peckoko_api#135

Open

BriceLgs mentioned this pull request Nov 12, 2024

[Snyk] Upgrade body-parser from 1.20.0 to 1.20.3 BriceLgs/p6#254

Open

Dmitry-White mentioned this pull request Nov 12, 2024

[Snyk] Upgrade body-parser from 1.20.2 to 1.20.3 Dmitry-White/Node.js-Playground#1213

Open

OlajideTechie mentioned this pull request Nov 12, 2024

[Snyk] Upgrade body-parser from 1.9.0 to 1.20.3 OlajideTechie/nodejs-goof#2

Open

lilocruz mentioned this pull request Nov 12, 2024

[Snyk] Upgrade body-parser from 1.20.2 to 1.20.3 lilocruz/Fusion_CI-CD#21

Open

audreynieketien mentioned this pull request Nov 12, 2024

[Snyk] Upgrade body-parser from 1.9.0 to 1.20.3 audreynieketien/nodejs-goof#2

Open

officialmofabs mentioned this pull request Nov 12, 2024

[Snyk] Upgrade body-parser from 1.19.0 to 1.20.3 ecampuslearning/remote-container#229

Open

devarmenchik1408 mentioned this pull request Nov 13, 2024

[Snyk] Upgrade body-parser from 1.18.2 to 1.20.3 devarmenchik1408/adobe-dev-console#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: fix errors in ci github action for node 8 and 9 #523

ci: fix errors in ci github action for node 8 and 9 #523

inigomarquinez commented May 5, 2024

inigomarquinez commented May 5, 2024

UlisesGascon left a comment

wesleytodd commented May 15, 2024

wesleytodd commented May 17, 2024

inigomarquinez commented May 18, 2024

wesleytodd commented May 22, 2024

inigomarquinez commented May 24, 2024

ctcpip commented May 31, 2024

ci: fix errors in ci github action for node 8 and 9 #523

ci: fix errors in ci github action for node 8 and 9 #523

Conversation

inigomarquinez commented May 5, 2024

inigomarquinez commented May 5, 2024

UlisesGascon left a comment

Choose a reason for hiding this comment

wesleytodd commented May 15, 2024

wesleytodd commented May 17, 2024

inigomarquinez commented May 18, 2024

wesleytodd commented May 22, 2024

inigomarquinez commented May 24, 2024

ctcpip commented May 31, 2024