Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I find out that while calling
getFunc(...)
, when the kind of val isMap
, will only assume the method is provide by k-v. But even a map can have it is own method, and it will help a lot.For example:
In this cases,
ExprParams
can provide default method ( likeMax
) easily.And the implement is very simple, I hope it can improve the lib.
Thanks a lot.
PS: another question
I find that the only to calling for
getFunc(val interface{}, i interface{})
, the parami
is bothstring
, why not just change thegetFunc(...)
togetFunc(val interface{}, funcName string)
? That will save the cost ofreflect.ValueOf(i).String()