-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade @sentry/react-native to 5.9.1 #367
Conversation
package.json
Outdated
"@sentry/types": "7.52.1", | ||
"@sentry/integrations": "7.60.1", | ||
"@sentry/react": "7.60.1", | ||
"@sentry/react-native": "5.8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we upgrade all the way to 5.9.1?
I'm hoping to get sentry profiling up and running on an Expo app as well - would be great to get this merged in @kbrandwijk! |
Done, but needs some testing |
Any plans to merge this soon? |
Tested with 5.9.1 and it works. Build on XCode 15 with iOS17. Also rebased to current main branch |
33f65c5
to
24e7dda
Compare
Any plans to merge this in? We're excited to get profiling up and running to help debug some performance issues |
Seems it was updated already in the meantime.. will close this PR |
Checklist
Why
Sentry offers profiling in beta state since version 5.8.0 of @sentry/react-native. Upgrading to latest 5.9.1
How
Updated the package and peer versions accordingly to @sentry/react-native.
Test Plan
Used an expo app and included the new version. Sentry log shows 5.9.1