upgrade @sentry/react-native to 5.9.1 #367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| "@sentry/types": "7.52.1", | ||
| "@sentry/integrations": "7.60.1", | ||
| "@sentry/react": "7.60.1", | ||
| "@sentry/react-native": "5.8.0", |
There was a problem hiding this comment.
Can we upgrade all the way to 5.9.1?
|
I'm hoping to get sentry profiling up and running on an Expo app as well - would be great to get this merged in @kbrandwijk! |
Done, but needs some testing |
mroswald
changed the title
|
Any plans to merge this soon? |
|
Tested with 5.9.1 and it works. Build on XCode 15 with iOS17. Also rebased to current main branch |
mroswald
force-pushed
the
upgrade-sentry-react-native-580
branch
from
33f65c5
to
24e7dda
Compare
|
Any plans to merge this in? We're excited to get profiling up and running to help debug some performance issues |
1 task
|
Seems it was updated already in the meantime.. will close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Why
Sentry offers profiling in beta state since version 5.8.0 of @sentry/react-native. Upgrading to latest 5.9.1
How
Updated the package and peer versions accordingly to @sentry/react-native.
Test Plan
Used an expo app and included the new version. Sentry log shows 5.9.1