fix: Dynamically resolve collectModulesScript script path to support monorepos
#343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @krystofwoldrich , my team could use this update. Any idea when this might be merged/released? Thanks! |
|
We need this too! Expo 48 + Turpoero setup - same issue. @krystofwoldrich |
sergey-king
approved these changes
Jun 16, 2023
kbrandwijk
approved these changes
Jun 19, 2023
kbrandwijk
pushed a commit
that referenced
this pull request
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @anirudhsama and @maximgeerinck for the original workaround.
Checklist
Why
Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests.
closes: #342
How
How did you build this feature or fix this bug and why?
This is already fixed in
sentry-react-native. But until released and upgraded here, this PR will work for all the versions.getsentry/sentry-react-native#3092
Test Plan
Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.
Sample app and other users from #342