Skip to content

Commit

Permalink
Check that WS connection is open before closing it on failed. Fixes f…
Browse files Browse the repository at this point in the history
…acebook#3346

Summary: Check that the WS state is set to OPEN before trying to close it when the ```websocketFailed``` event fires. Otherwise the app throws an error at the Android level.

Fixes facebook#3346
Closes facebook#3347

Reviewed By: @​svcscm

Differential Revision: D2535807

Pulled By: @mkonicek

fb-gh-sync-id: bb70c551ea2e582cfaa80139a265dbbca6d990d2
  • Loading branch information
yzarubin authored and ide committed Oct 23, 2015
1 parent 1aa2cc4 commit 3127ce1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Libraries/WebSocket/WebSocket.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ class WebSocket extends WebSocketBase {
this.onerror && this.onerror(event);
this.dispatchEvent(event);
this._unregisterEvents();
this._closeWebSocket(id);
this.readyState === this.OPEN && this._closeWebSocket(id);
})
];
}
Expand Down

0 comments on commit 3127ce1

Please sign in to comment.