[image-picker][android] Support using legacy image picker #28514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: passed checks
3 tasks
|
Thank again Alan! Appreciate it! |
|
The Pull Request introduced fingerprint changes against the base commit: 1eccf32 Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-image-picker/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "71084e0d3ccf866aa92e542bc04e4fbfe2f6867b"
}
]Generated by PR labeler 🤖 |
|
No problem @haileyok! Thanks for the PR, I should have done this a while ago 😅 |
alanjhughes
requested review from
Simek,
amandeepmittal and
lukmccall
as code owners
lukmccall
approved these changes
Apr 29, 2024
amandeepmittal
approved these changes
Apr 29, 2024
alanjhughes
deleted the
@alanhughes/image-picker/support-new-and-old-picker
branch
|
To be able to use the legacy picker is a great option for some use cases, thank you for the effort you put into it. Although the legacy picker is available in Android 13, it seems like later Android versions do not support it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes #27117
Follow up from #28510. Gives users an option to use the legacy method for picking media on android.
How
Added a new option to
ImagePickerOptions,legacy, and updated the docs.cc @haileyok
Test Plan
bare-expo ✅