-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[expo-av][iOS] Fix compilation on tvOS #24864
[expo-av][iOS] Fix compilation on tvOS #24864
Conversation
ENG-10042 Add Apple TV support to Expo SDK
Now that React Native TV repo is at 0.72.4, even with core, we can start adding partial support for Apple TV. Included:
Possibly included in future:
Excluded:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. didn't check the code in EXAVTV.m though. it would be even better if we in the future could split shared code into base class like EXAVBase.m.
Since we mostly just need to remove methods related to audio, I'm more in favor of not supporting tvOS in |
@tsapeta since
What do you think? |
5dc5f0c
to
2e235b7
Compare
2e235b7
to
6bec08c
Compare
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
# Why Allow the `expo-av` module to compile on Apple TV. # How To safely do this without heavy modification of `EXAV.m`, the podspec is modified so that tvOS uses a separate module implementation `EXAVTV.m`, with the audio recording code removed and stub module methods for those features. # Test Plan - Tested on a test app with Expo 50 alpha packages and the TV plugin - CI should continue to pass # Checklist - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Why
Allow the
expo-av
module to compile on Apple TV.How
To safely do this without heavy modification of
EXAV.m
, the podspec is modified so that tvOS uses a separate module implementationEXAVTV.m
, with the audio recording code removed and stub module methods for those features.Test Plan
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).