fix(router): Drawer layout incorrect position on initial load #24197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
expo/router#837
ExpoRouter provides a
SafeAreaContextProvider
with an initial value of0
for all dimensions. Thedrawer
layout uses these dimensions to calculate the necessary x offset for its 'closed' state. These calculations assume a minimum screen size, so having0
caused it to initially render on the screenHow
We only need these initial values for static rendering, so now we only provide them when rendering SSR.
Test Plan
Tested manually by creating a new project.
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).