Type-checking improvements #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicknovitski
requested review from
a team and
vonovak
and removed request for
a team
nicknovitski
force-pushed
the
tsc-strictest
branch
from
fe0b583 to
5fb64fa
Compare
nicknovitski
force-pushed
the
tsc-strictest
branch
from
5fb64fa to
430da44
Compare
vonovak
approved these changes
Sep 8, 2024
- Running `tsc` with no options checks every file (`build` still builds source, like before) - Use jest's built-in types - Enable strictest typechecking settings - The test workflow runs `yarn tsc` - The test workflow installs @types/node
nicknovitski
force-pushed
the
tsc-strictest
branch
from
531b197 to
6d2443a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
tscwith no options checks every file (buildstill buildssource, like before)
yarn tsc