Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom sounds #110

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

vonovak
Copy link
Contributor

@vonovak vonovak commented Nov 26, 2024

Usage

This is for iOS only. Android sounds are specified via channelId docs.

When you configure a sound in our config plugin (docs.expo.dev/versions/latest/sdk/notifications#configurable-properties) you can then refer the sound in the sound field.

example:

sound: 'bells_sound.wav',

If an invalid sound file (one that doesn't exist in the application bundle on the device) is specified in payload to Expo Push, default is played instead. Keep in mind sounds aren't played in silent mode or focus modes that may be set by user.

@vonovak vonovak requested a review from a team as a code owner November 26, 2024 16:15
@vonovak vonovak requested review from douglowder and removed request for a team November 26, 2024 16:15
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (07bbb73) to head (a31468d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #110   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          168       168           
  Branches        33        32    -1     
=========================================
  Hits           168       168           
Flag Coverage Δ
node_18 100.00% <ø> (ø)
node_20 100.00% <ø> (ø)
node_22 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@douglowder douglowder merged commit 131a4d0 into main Dec 3, 2024
5 checks passed
@douglowder douglowder deleted the @vonovak/feat_support_custom_sounds branch December 3, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants