This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
Revert "fix(webpack-config): fix sourcemap bug with expo camera" #4746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 71c32d4.
|
Probably ok to keep these around for a while since the webpack config isn't versioned with the SDK. |
EvanBacon
pushed a commit
to expo/expo
that referenced
this pull request
Aug 16, 2023
# Why `@koale/useworker` is only used for Web QR code scanning and has been causing some issues due to lack of maintenance. Fixes: #17846 Related: #23296, and the PR to revert its 'fix' expo/expo-cli#4746 # How Refactors the existing code to use vanilla JS 1. We create a inline webworker by creating an inline blob with `qrWorkerMethod.toString()` (code adapted from `@koale/useworker`) 2. Create a smaller wrapper that tracks messages being sent to the worker via a queue of promises As the worker is synchronous and will receive messages in order a simple First In First Out queue should suffice. This does _slightly_ change the functionality of the existing code. 1. Previously we created a new Worker for every instance of `<Camera />`. Now a single worker is shared across all instances. 1. As the worker is declared in the global scope, it is created regardless if QR code scanning is enabled. We could lazy initialise it, but because its extremely small and inline (no network requests) I don't see this being an issue. I also removed an extra `useEffect` hook by moving its logic into the cleanup step of the enabling hook.
EvanBacon
pushed a commit
to expo/expo
that referenced
this pull request
Aug 23, 2023
# Why `@koale/useworker` is only used for Web QR code scanning and has been causing some issues due to lack of maintenance. Fixes: #17846 Related: #23296, and the PR to revert its 'fix' expo/expo-cli#4746 # How Refactors the existing code to use vanilla JS 1. We create a inline webworker by creating an inline blob with `qrWorkerMethod.toString()` (code adapted from `@koale/useworker`) 2. Create a smaller wrapper that tracks messages being sent to the worker via a queue of promises As the worker is synchronous and will receive messages in order a simple First In First Out queue should suffice. This does _slightly_ change the functionality of the existing code. 1. Previously we created a new Worker for every instance of `<Camera />`. Now a single worker is shared across all instances. 1. As the worker is declared in the global scope, it is created regardless if QR code scanning is enabled. We could lazy initialise it, but because its extremely small and inline (no network requests) I don't see this being an issue. I also removed an extra `useEffect` hook by moving its logic into the cleanup step of the enabling hook.
brentvatne
pushed a commit
to expo/expo
that referenced
this pull request
Sep 7, 2023
`@koale/useworker` is only used for Web QR code scanning and has been causing some issues due to lack of maintenance. Fixes: #17846 Related: #23296, and the PR to revert its 'fix' expo/expo-cli#4746 Refactors the existing code to use vanilla JS 1. We create a inline webworker by creating an inline blob with `qrWorkerMethod.toString()` (code adapted from `@koale/useworker`) 2. Create a smaller wrapper that tracks messages being sent to the worker via a queue of promises As the worker is synchronous and will receive messages in order a simple First In First Out queue should suffice. This does _slightly_ change the functionality of the existing code. 1. Previously we created a new Worker for every instance of `<Camera />`. Now a single worker is shared across all instances. 1. As the worker is declared in the global scope, it is created regardless if QR code scanning is enabled. We could lazy initialise it, but because its extremely small and inline (no network requests) I don't see this being an issue. I also removed an extra `useEffect` hook by moving its logic into the cleanup step of the enabling hook.
byCedric
added
question
byCedric
removed
the
expo:internal-discussion
|
Closing this due to inactivity. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4735
We are removing
@koale/useworkerso these rules can be movedexpo/expo#23967