Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Created @expo/api package #3361

Merged
merged 32 commits into from
Jan 24, 2022
Merged

Created @expo/api package #3361

merged 32 commits into from
Jan 24, 2022

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Apr 7, 2021

Why

  • Resolve ENG-2819
  • Split modules out of xdl and into a new internal package @expo/api. This will enable us to authenticate and sign manifests from npx expo without needing to fully depend on xdl which contains deprecated ExpoKit logic.
  • Decouples user auth from the rest of xdl.
  • Might make sense to combine Config.offline with ConnectionStatus.
  • Maybe split up Config and only keep relevant parts in expo/api.
  • Config -> SessionSettings to fit the other settings naming conventions.
  • Type all input/output for network requests.

How

Test Plan

  • Ensure all tests continue to work.
  • Split up e2e and unit tests from expo-cli runs.
  • Manually run expo login, expo whoami, expo logout, expo publish (app with assets), expo start, expo publish:history.

@EvanBacon EvanBacon requested a review from fson April 7, 2021 04:41
packages/api/package.json Show resolved Hide resolved
packages/api/package.json Outdated Show resolved Hide resolved
packages/api/src/Analytics.ts Outdated Show resolved Hide resolved
packages/expo-cli/src/accounts.ts Outdated Show resolved Hide resolved
@EvanBacon
Copy link
Contributor Author

stale

@EvanBacon EvanBacon closed this Apr 21, 2021
@EvanBacon EvanBacon deleted the @evanbacon/api/create-package branch April 21, 2021 19:18
@EvanBacon EvanBacon restored the @evanbacon/api/create-package branch January 11, 2022 22:58
@EvanBacon EvanBacon reopened this Jan 11, 2022
@EvanBacon EvanBacon changed the base branch from master to main January 12, 2022 23:49
Consolidate settings

Drop lodash

dotExpoHomeDirectory -> getDirectory

rename lte and gte methods

ExpSchema -> ExpoConfigSchema

Refactor Cache

fix bugs
fix up function names
@linear
Copy link

linear bot commented Jan 20, 2022

Update README.md

Update startAsync.ts

lint fix

fixup tests

Split up Publish API

Refactor API

Refactor

Update getPublishExpConfigAsync.ts
@EvanBacon EvanBacon force-pushed the @evanbacon/api/create-package branch from a16a843 to a8a5397 Compare January 20, 2022 04:54
Cleaned up API

Moved ProjectSettings to api

Delete unused Session module

Update ArtifactUtils.ts

Config -> ProcessSettings

move downloadAppAsync back to xdl

Updated Versions API

Clean up API

fixed whoami

fix tests

fix bugs

Update exportAppAsync-test.ts

Update exportAppAsync-test.ts

Update npm-test.ts

Updated docs

Updated docs

Update ProjectSettings.ts

fix mocks for path

fix mocks

fix dev tools mock

Update autoAddConfigPluginsAsync-test.ts

split up e2e

split up e2e

added node matrix
@EvanBacon EvanBacon force-pushed the @evanbacon/api/create-package branch from 9867165 to 4082a60 Compare January 21, 2022 20:03
@EvanBacon EvanBacon marked this pull request as ready for review January 21, 2022 20:15
@EvanBacon EvanBacon merged commit 282ac13 into main Jan 24, 2022
@EvanBacon EvanBacon deleted the @evanbacon/api/create-package branch January 24, 2022 21:07
Copy link
Member

@byCedric byCedric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EvanBacon added a commit that referenced this pull request Jan 26, 2022
EvanBacon added a commit that referenced this pull request Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants