This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fson
suggested changes
Apr 7, 2021
stale |
Consolidate settings Drop lodash dotExpoHomeDirectory -> getDirectory rename lte and gte methods ExpSchema -> ExpoConfigSchema Refactor Cache fix bugs
fix up function names
Update README.md Update startAsync.ts lint fix fixup tests Split up Publish API Refactor API Refactor Update getPublishExpConfigAsync.ts
a16a843
to
a8a5397
Compare
Cleaned up API Moved ProjectSettings to api Delete unused Session module Update ArtifactUtils.ts Config -> ProcessSettings move downloadAppAsync back to xdl Updated Versions API Clean up API fixed whoami fix tests fix bugs Update exportAppAsync-test.ts Update exportAppAsync-test.ts Update npm-test.ts Updated docs Updated docs Update ProjectSettings.ts fix mocks for path fix mocks fix dev tools mock Update autoAddConfigPluginsAsync-test.ts split up e2e split up e2e added node matrix
9867165
to
4082a60
Compare
byCedric
reviewed
Jan 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
EvanBacon
added a commit
that referenced
this pull request
Jan 26, 2022
This reverts commit 282ac13.
EvanBacon
added a commit
that referenced
this pull request
Jan 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
@expo/api
. This will enable us to authenticate and sign manifests fromnpx expo
without needing to fully depend on xdl which contains deprecated ExpoKit logic.Config.offline
withConnectionStatus
.Config
and only keep relevant parts inexpo/api
.Config
->SessionSettings
to fit the other settings naming conventions.How
Test Plan
expo login
,expo whoami
,expo logout
,expo publish
(app with assets),expo start
,expo publish:history
.