Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Update web index.html height style #3199

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Update web index.html height style #3199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/webpack-config/web-default/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
scroll-behavior: smooth;
/* Prevent text size change on orientation change https://gist.github.com/tfausak/2222823#file-ios-8-web-app-html-L138 */
-webkit-text-size-adjust: 100%;
height: 100%;
height: calc(100% + env(safe-area-inset-top));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, interesting idea. Have you tested this behavior with react-native-safe-area-context (react-navigation), landscape mode on iOS (resizing header bar)? Could you please add a "test plan" to your PR description:

# Test Plan

...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it works! I added screenshots to the test plan showing the behavior with react-navigation bottom tabs and header, with SafeArea component and with landscape mode.

}

body {
Expand Down