This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[xdl] Handle errors when trying to sign the manifest #3148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentvatne
approved these changes
Jan 28, 2021
byCedric
reviewed
Jan 28, 2021
| manifestString = await getManifestStringAsync(manifest, hostInfo.host, acceptSignature); | ||
| } else if (error.code === 'ENOTFOUND') { | ||
| // Got a DNS error, i.e. can't access exp.host, warn and enable offline mode. | ||
| addSigningDisabledWarning(projectRoot, 'Not connected to internet.'); |
There was a problem hiding this comment.
For users in countries where you might need a VPN, this could be confusing. They could have access to "the internet" but not exp.host.
- Maybe rewording this to "Could not reach the Expo servers" might be better?
- Or even better, add tips for the user to manually test/fix connection (e.g. "Could not reach Expo servers, please check if you can access exp.host")
There was a problem hiding this comment.
Great point, I'll update the wording here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
ManifestHandlertries to sign the manifest (requested by the client), automatically handle typical errors and fall back to offline mode:The project has an
ownerspecified, but you lack permissions to that account -> fall back to offline mode! Fixes Not authorized error when running project in development with owner field #3062.You don't have an internet connection, which results in
Error: getaddrinfo ENOTFOUND exp.host-> fall back to offline mode! Fixes Automatically switch to offline mode when manifest can't be signed #238.