Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Drop nodeModulesPath support #3141

Merged
merged 11 commits into from
Feb 1, 2021
Merged

Drop nodeModulesPath support #3141

merged 11 commits into from
Feb 1, 2021

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Jan 27, 2021 •
edited
Loading

@EvanBacon EvanBacon requested a review from brentvatne January 27, 2021 23:00
@EvanBacon EvanBacon changed the title Update ExpoConfig.ts Drop nodeModulesPath support Jan 29, 2021
brentvatne
brentvatne approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@brentvatne brentvatne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭 nodeModulesPath is the worst and i hope nothing ends up coming up when we release this because i really don't want it to exist anymore

packages/config-types/src/ExpoConfig.ts Show resolved Hide resolved
packages/expo-cli/src/commands/install.ts Show resolved Hide resolved
packages/expo-optimize/src/assets.ts Outdated Show resolved Hide resolved
@EvanBacon EvanBacon merged commit 5e82773 into master Feb 1, 2021
@EvanBacon EvanBacon deleted the @evanbacon/config-types/update-node-modules branch February 1, 2021 23:21
@louisgv louisgv mentioned this pull request Mar 10, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brentvatne brentvatne brentvatne approved these changes

Assignees
No one assigned
Labels
🧹 chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EvanBacon @brentvatne