This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[config] fix: add files to 'copy bundle resources', not 'compile sour… #2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ces' build phase
why
the two instances where this function is used are:
GoogleService-Info.plistto the projectIn both of those instances, when you follow the relevant guides for them, the respective files are added to the "Copy Bundle Resources" build phase, not the "Compile Sources" build phase (google services guide and localization guide)
Placing them in the compile sources build phase causes errors like the one failing this build- https://expo.io/accounts/charliecruzan/builds/v2/9595f8bb-cd42-4208-8c30-c8e3b6f7d05d/logs
test plan
ran eject locally, here's the result: