This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[xdl]<fix>: Remove default splash screen image on Android #2883
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user does not provide a splash image we shouldn't show any image.
Ensured the splash screen image from Expo Client is not propagated to standalones.
Resolves https://forums.expo.io/t/how-to-remove-default-expo-splash-screen/44789/2
Test plan
I've jumped back to
sdk-39
branch, build local standalone simulator app for Android.TODOs
xdl
-rc
version on npm & update inturtle
on staging)xdl
with this change(back-porting to SDK 39) rebuildedit: this is not needed assdk-39
Android shell tarball using this newer xdl versionturtle
is running this piece of code@expo/xdl
version inturtle
and ship to production