This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[configure-splash-sceen]<feat>: Add missing --version, -V
#2785
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed that the
yarn expo-splash-screen
was missing aversion
option and therefore it was really hard to tell what version of this command the user is running.I've fetched the version from the
package.json
as this is the most reliable source.Unfortunately I had to change tsc project structure, because tsc was complaining.edit: I've had to adjust the
tsconfig
file to ignorejson
s, because importing the file from outside therootDir
(specified intsconfig
, andpackage.json
is outside thesrc
directory) would change thebuild
folder layout and will copy over thepackage.json
file and thatpackage.json
file duplication is not playing well withlerna
and other other tooling (CI was failing)