Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[xdl] Remove unused methods from Project module #2684

Merged
merged 4 commits into from
Sep 22, 2020
Merged

[xdl] Remove unused methods from Project module #2684

merged 4 commits into from
Sep 22, 2020

Conversation

EvanBacon
Copy link
Contributor

  • Remove deprecated methods
  • Delete seemingly unused functions and types from Project module.

@EvanBacon EvanBacon self-assigned this Sep 22, 2020
fson
fson approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@fson fson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! 🎉

Just see the note about getSlugAsync, maybe it can be removed too.

packages/expo-cli/src/commands/utils/PublishUtils.ts Outdated Show resolved Hide resolved
@EvanBacon EvanBacon removed the request for review from quinlanj September 22, 2020 16:31
@EvanBacon EvanBacon merged commit 2f323ca into master Sep 22, 2020
@EvanBacon EvanBacon deleted the @evanbacon/xdl/remove-unused-from-project branch September 22, 2020 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fson fson fson approved these changes

Assignees

@EvanBacon EvanBacon

Labels
🧹 chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EvanBacon @fson