[expo-cli] Allow manually provided credentials when keytool is missing

[wkozyra95]

Why

When keytool was missing update process was stopped before the user had a chance to select the option to manually provide credentials.

How

Move keytool check to later stage

Test plan

Remove keytool and run expo build:android -c

[quinlanj]

IIUC, we are passing in additional options into the UpdateKeystore constructor because we expect different behaviours in credentials:manager vs build:android.

In the event the user doesn't have the keytool binary, we want:

• credentials:manager to throw, because the user is specifically asking for client side generation of Keystore
• build:android to return null, because we will generate a Keystore for the user on the Expo servers.

[quinlanj]

Suggested change

	} else if (this.options.optionalKeystoreGeneration && !(await keytoolCommandExists())) {
	}
	const userHasKeytoolCommand = await keytoolCommandExists();
	if (!userHasKeytoolCommand) {
	if (this.options.bestEffortKeystoreGeneration) {
	// we tried our best to generate the keystore on the client side
	return null;
	}
	throw new Error('The keytool binary is not installed. A Keystore will be generated on the Expo servers during your next build.');
	}

[quinlanj]

Suggested change

	optionalKeystoreGeneration: boolean;
	bestEffortKeystoreGeneration: boolean; // don't error if user doesn't have the binaries to generate a Keystore

[wkozyra95]

@quinlanj

In the event the user doesn't have the keytool binary, we want:
credentials:manager to throw, because the user is specifically asking for client side generation of Keystore
build:android to return null, because we will generate a Keystore for the user on the Expo servers.

If I did not miss anything this code has the same exact behaviour as with your changes. The only difference is that I'm throwing an error when cli attempts to generate Keystore and with your changes, it's happening based on userHasKeytoolCommand value.

bestEffortKeystoreGeneration is a better name, so I'll update that

[quinlanj]

@wkozyra95 ok sounds good to me, just wanted to make sure we were not missing anything!