This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[cli] add missing owner query param #2660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkozyra95
approved these changes
Sep 17, 2020
cruzach
approved these changes
Sep 17, 2020
|
+ reminder to add a note about this to the changelog |
quinlanj
force-pushed
the
@quin/fixCredsBug
branch
from
685e834
to
c10c685
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
This PR fixes a bug reported by our users.
We've set up all our credentials endpoints to accept an
ownerparameter so we can fetch the correct credentials and perform permissioning checks.When a team member tries to get the project owner's user credentials, the
ownerparameter must be set in the API call otherwise the server will return a permissioning error.