Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[xdl] delete deprecated Exp code #2590

Merged
merged 5 commits into from
Sep 8, 2020

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Sep 7, 2020

  • Move git command to expo init
  • Move installDependenciesAsync to init
  • Move js-yaml to expo-cli
  • Delete unused packages/expo-cli/src/commands/push-creds-web.ts which invoked deprecated methods

- move git command to expo init
- move js-yaml to expo-cli
@EvanBacon EvanBacon requested a review from fson September 7, 2020 10:38
@EvanBacon EvanBacon self-assigned this Sep 7, 2020

// TODO: remove / change, no longer publishInfo, this is just used for signing
/** @deprecated use getConfig from @expo/config */
export async function getPublishInfoAsync(root: string): Promise<PublishInfo> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@fson fson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvanBacon EvanBacon merged commit d6368c3 into master Sep 8, 2020
@EvanBacon EvanBacon deleted the @evanbacon/xdl/delete-deprecated-exp-code branch September 8, 2020 11:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants