This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[xdl] pass app.json updates config to expo-updates in standalone apps #2539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes expo/expo#9922, along with expo/expo#9985
This PR passes the
updates.checkAutomatically
andupdates.fallbackToCacheTimeout
app.json values, which were previously set at runtime, into build-time configuration values for standalone apps built by turtle. These values will then be read and passed directly to expo-updates by the ExpoKit kernels.Further, starting with SDK 39 the filenames that the ExpoKit kernel expects for the embedded manifest and bundle have changed, from
shell-app-manifest.json
andshell-app.bundle
toapp.manifest
andapp.bundle
. This PR makes that change accordingly for building standalone apps.