This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[expo-cli] Fix 'generate-module' to support latest expo-module-template #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkozyra95
approved these changes
Aug 28, 2020
barthap
force-pushed
the
@barthap/generate-module-fix
branch
from
0cb959d
to
a626118
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Due to expo/expo#9319, package
expo-module-templateschanged directory structure (kotlinwas renamed tojavaunderandroid/src/main).Currently, npm-published
expo-module-template@8.3.1tagged aslateststill haskotlindirectory, but version8.4.0/nexthas that directory renamed.Current CLI
expo generate-moduleexpectskotlinas directory. This PR prepares it to also expectjava.How
Created a function to check which of these directories exist. If both - choose java; if none - throw human readable error.
Test plan
Tested for both
expo-module-templateversions (latestandnext). Also tested for package with invalid directory structure.