Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[expo-cli] eas build: allow choosing scheme for ios project build #2501

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

dsokal
Copy link
Contributor

@dsokal dsokal commented Aug 25, 2020

This fixes an issue with building a project initialized with react-native init. Such a project has multiple schemes in the Xcode project. fastlane is unable to build the project if we don't specify the target explicitly. This PR fixes it by displaying a prompt select to choose the build scheme if multiple schemes were detected. If the CLI is run with the --non-interactive flag then the first scheme (without the tvOS suffix) is picked.

@dsokal dsokal requested a review from wkozyra95 August 25, 2020 12:18
@dsokal dsokal changed the title [expo-cli] eas build: allow for choosing scheme for ios project build [expo-cli] eas build: allow choosing scheme for ios project build Aug 25, 2020
@dsokal dsokal requested a review from wkozyra95 August 25, 2020 13:30
Copy link
Member

@brentvatne brentvatne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, i like this solution

@dsokal dsokal merged commit 8ce3c3b into master Aug 26, 2020
@dsokal dsokal deleted the @dsokal/mutliple-schemes branch August 26, 2020 09:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants