This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
Prompt for bundle ID and package name in expo apply #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
deleted the
@evanbacon/apply/prompt-bundle-id-and-package-name
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now
expo applycrashes if the project config doesn't have a bundle ID or package name defined. This prompts the user for the appropriate values using the same logic as eject.This code does however get executed twice now when ejecting, but it might be ok since it's important that the command bails out as quickly as possible in
expo eject.Also added the ability to run in projects without Expo configs. I modified the order of operations, so Android config is done first, this way the package name is optimized for being shared across iOS and Android.