Generate iOS icons on eject and apply #2495

EvanBacon · 2020-08-24T23:13:16Z

How

Read icons from config on eject and apply
Utilize image-utils to switch between global sharp-cli instance and jimp. If I'm not mistaken, this'll add a noticeable amount to the package size due to the Jimp instance.
- This package also caches the images in .expo based on the image hash so reapplying is very quick since it only needs to copy the images.
- Also support for remote URLs as icons works too -- this may not apply to other tools in the CLI.
Resize icons to squares with white backgrounds to ensure shape and limited transparency
- Does not fully remove the alpha channel when using with sharp, it does with Jimp though. I'm almost certain transparency cannot be added to the image regardless.
Use Contents.json to reuse icons across platforms.

Test Plan

Wrote tests to ensure the expected amount of images are generated and the icon resolution works as expected.

brentvatne

this is great, thank you for leaving detailed comments in addition to the tests

brentvatne · 2020-08-25T18:54:40Z

packages/config/src/ios/Icons.ts

+        if (!(filename in generatedIcons)) {
+          const iconSizePx = size * scale;
+
+          // Using this method will cache the images in `.expo` based on the properties used to generate them.


brentvatne · 2020-08-25T18:57:23Z

packages/config/src/ios/utils/Xcodeproj.ts

-export function getSourceRoot(projectRoot: string) {
-  const paths = globSync('ios/*/AppDelegate.m', {
+export function getSourceRoot(projectRoot: string): string {
+  // Account for Swift or Objective-C


EvanBacon added 2 commits August 24, 2020 15:48

Generate iOS icons on eject and apply

89594d5

Remove transparency

c6bac5c

EvanBacon added enhancement New feature or request expo eject This issue pertains to the command expo eject labels Aug 24, 2020

EvanBacon requested a review from brentvatne August 24, 2020 23:13

EvanBacon self-assigned this Aug 24, 2020

EvanBacon added 2 commits August 24, 2020 16:14

Update package.json

4f962c2

updated tests

5148bcc

brentvatne approved these changes Aug 25, 2020

View reviewed changes

EvanBacon added 3 commits August 25, 2020 13:08

Update Icons-test.ts

9e39666

Update Icons-test.ts

5da7a18

mock all tests

b68f36b

EvanBacon merged commit 4aab89e into master Aug 25, 2020

EvanBacon deleted the @evanbacon/config/generate-ios-icons branch August 25, 2020 21:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate iOS icons on eject and apply #2495

Generate iOS icons on eject and apply #2495

EvanBacon commented Aug 24, 2020

brentvatne left a comment

brentvatne Aug 25, 2020

brentvatne Aug 25, 2020

Generate iOS icons on eject and apply #2495

Generate iOS icons on eject and apply #2495

Conversation

EvanBacon commented Aug 24, 2020

How

Test Plan

brentvatne left a comment

Choose a reason for hiding this comment

brentvatne Aug 25, 2020

Choose a reason for hiding this comment

brentvatne Aug 25, 2020

Choose a reason for hiding this comment