This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[cli][eject] Support projects with dynamic or missing configs #2464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
expo eject
in a project foldermy-cool-app
(which doesn't have a config or name), the suggestion would've been blank cuzcom.bacon.my-cool-app
is invalid. Now it'll recommendcom.bacon.mycoolapp
../app.json
--config
because those are validated beforehand../app.json
which fails when a project uses a dynamicapp.config.js
file.