This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[xdl] Expand Android permissions blacklist and add annotations #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement PR for #2307, and part of expo/expo#9499. It adds some annotations to the permission list to know why permissions are or were added. This, together with the new Danger script that warns people when adding new permissions to android manifests should keep this up to date in the future 🚀
The following permissions are added to the list:
android.permission.USE_BIOMETRIC- Is part of the new Biometric Prompt in Android forexpo-local-authentication.android.permission.SYSTEM_ALERT_WINDOW- Is only required for debugging (e.g. in Expo Client), not required in production apps.android.permission.REQUEST_INSTALL_PACKAGES- This is dangerous/signature permission and might get apps rejected when used.android.permission.ACCESS_BACKGROUND_LOCATION- Added inexpo-locationbut not in here.Keep in mind that adding these to the blacklist doesn't prevent users to include the permissions. It only switches the permission from automatically added to manually included in the
android.permissionsmanifest property list 😄